danielcweeks commented on code in PR #18252:
URL: https://github.com/apache/iceberg/pull/18252#discussion_r4540010906
##########
api/src/main/java/org/apache/iceberg/types/TypeUtil.java:
##########
@@ -639,11 +667,47 @@ private static int estimateSize(Type type) {
/** Interface for passing a function that assigns column IDs. */
public interface NextID {
int get();
+
+ default int get(int numReserved) {
Review Comment:
Commented elsewhere, but I think if we make this `get(<Type>)` the behavior
is more encapsulated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
