rdblue commented on a change in pull request #2096:
URL: https://github.com/apache/iceberg/pull/2096#discussion_r567325845



##########
File path: core/src/main/java/org/apache/iceberg/TableMetadataParser.java
##########
@@ -161,8 +163,19 @@ private static void toJson(TableMetadata metadata, 
JsonGenerator generator) thro
     generator.writeNumberField(LAST_UPDATED_MILLIS, 
metadata.lastUpdatedMillis());
     generator.writeNumberField(LAST_COLUMN_ID, metadata.lastColumnId());
 
-    generator.writeFieldName(SCHEMA);
-    SchemaParser.toJson(metadata.schema(), generator);
+    // for older readers, continue writing the current schema as "schema"

Review comment:
       Might want to note that this is done until v2 because support for 
`schemas` and `current-schema-id` is required in v2 and later.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to