pvary commented on code in PR #18694:
URL: https://github.com/apache/iceberg/pull/18694#discussion_r4548957401


##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##########
@@ -48,6 +49,13 @@ final class JdbcUtil {
   static final String METADATA_REFRESH_MAX_RETRIES_PROPERTY =
       JdbcCatalog.PROPERTY_PREFIX + "metadata-refresh-max-retries";
   static final int METADATA_REFRESH_MAX_RETRIES_DEFAULT = 20;
+  // catalog properties that must not be passed to the JDBC driver

Review Comment:
   nit: Maybe add a comment to highlight that every property should be listed?
   ```suggestion
     // Catalog properties that must not be passed to the JDBC driver. New 
catalog properties that use
     // JdbcCatalog.PROPERTY_PREFIX must be added to this set.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to