binarybrain-009 commented on code in PR #18694:
URL: https://github.com/apache/iceberg/pull/18694#discussion_r4549215992
##########
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcUtil.java:
##########
@@ -49,7 +49,24 @@ public void testFilterAndRemovePrefix() {
expected.put("pass", "secret");
expected.put("jdbc.abcxyz", "abcxyz");
- Properties actual = JdbcUtil.filterAndRemovePrefix(input, "jdbc.");
+ Properties actual = JdbcUtil.driverProperties(input);
+
+ assertThat(actual).isEqualTo(expected);
+ }
+
+ @Test
+ void driverPropertiesExcludeCatalogProperties() {
Review Comment:
Updated to public void testDriverPropertiesExcludeCatalogProperties in
ddca72dcf. TestJdbcUtil (8 tests), formatting, and core checkstyle checks pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]