pvary commented on code in PR #18691:
URL: https://github.com/apache/iceberg/pull/18691#discussion_r4549078745
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCatalog.java:
##########
@@ -374,6 +376,25 @@ public void dropViewShouldDropMetadataFileIfGcEnabled()
throws IOException {
assertThat(catalog.viewExists(identifier)).isFalse();
}
+ @ParameterizedTest(name = "purge = {0}")
+ @ValueSource(booleans = {false, true})
+ void dropTableDoesNotDropIcebergView(boolean purge) {
Review Comment:
Is this working for other catalogs?
If possible put this test to ViewCatalogTests, and if it fails with other
catalogs, then file a follow-up PR to fix it there too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]