binarybrain-009 commented on code in PR #18691:
URL: https://github.com/apache/iceberg/pull/18691#discussion_r4549488843


##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCatalog.java:
##########
@@ -374,6 +376,25 @@ public void dropViewShouldDropMetadataFileIfGcEnabled() 
throws IOException {
     assertThat(catalog.viewExists(identifier)).isFalse();
   }
 
+  @ParameterizedTest(name = "purge = {0}")
+  @ValueSource(booleans = {false, true})
+  void dropTableDoesNotDropIcebergView(boolean purge) {

Review Comment:
   Moved the test to ViewCatalogTests in da37190b4 and ran both purge settings 
against the catalog implementations. Hive, JDBC, in-memory, REST, and REST with 
assumed view support pass. Nessie throws a type-mismatch exception instead of 
returning false, so I opened #18912 as the separate fix, with a regression that 
fails before the change for both Nessie API versions. The full Nessie build 
passes with that fix (498 tests reported, 34 skipped, no failures). This PR 
temporarily disables only the inherited Nessie case, with a link to #18912, so 
it can land independently; that override can be removed once the follow-up 
lands. Formatting/checkstyle checks and the remaining Nessie view tests pass.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to