ajanko-shopify commented on PR #17901: URL: https://github.com/apache/iceberg/pull/17901#issuecomment-6826801512
Hi @fmorillo7694, thank you for this fix! We hit the same duplicate commits in production with blue/green Flink deployments, so we'd really like to see it merged. The PR has been quiet for a while, so I opened #18916 as a possible replacement. It keeps your commit and authorship, rebases onto `main`, and adds a second commit that: - moves `MaxCommittedCheckpointIdValidator` into `SinkUtil`, as @mxm asked; - adapts it to #18303, which changed `DynamicCommitter` to identify its snapshots by sink ID; - validates in `IcebergCommitter` only after a restore, to match #18123. Otherwise, the validator skips commits after a stateless restart, which `testCommitTxnAfterStatelessRestart` catches. If you'd prefer to continue here, that's completely fine. Feel free to take anything useful from #18916, and I'll close it without merging. Please just let us know which way you'd like to go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
