fmorillo7694 commented on PR #17901: URL: https://github.com/apache/iceberg/pull/17901#issuecomment-6858662485
Thanks @mxm, agreed. I rebased onto `main` with #18807. The in-commit validator now matches by sink ID through `SinkUtil.writtenBySameSink`, the same check as the up-front read, so `isRestored` is gone. `getMaxCommittedCheckpointId` is back to its `main` version. `TestIcebergCommitter`, `TestIcebergSink`, `TestIcebergSinkV2`, `TestIcebergFilesCommitter`, `TestDynamicCommitter`, `TestDynamicIcebergSink` and the duplicate-commit test pass. The duplicate-commit test fails without the validator; `testCommitTxnAfterStatelessRestart` passes either way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
