AynSiddiqui commented on issue #2443: URL: https://github.com/apache/iceberg-go/issues/2443#issuecomment-6823704367
Agreed on all four. #2492 is rebased on main and now covers 3 and 4: create view sends the header, and when the server advertises a lifetime, a configured default `Idempotency-Key` is dropped from every request after the initial `GET /v1/config` (support isn't known before that). It's ready for review. 1 and 2 go into the retry PR: a key is reused only for resends of the same request after a 5xx, timeout or connection error, never after a 4xx; resends stop once the lifetime has passed since the first attempt and return `ErrCommitStateUnknown`; a missing or zero lifetime means no keyed resends. The scan planning POSTs will follow the same rules there. I'll post a short design note here before starting it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
