kevinjqliu commented on code in PR #18660:
URL: https://github.com/apache/iceberg/pull/18660#discussion_r4556653470
##########
runtime-deps.gradle:
##########
@@ -78,14 +87,14 @@ tasks.register('generateRuntimeDeps') {
}
}
-tasks.register('checkRuntimeDeps') {
+tasks.maybeCreate('checkRuntimeDeps').configure {
group = 'verification'
description = 'Verify runtime dependencies match the checked-in baseline'
- inputs.files(configurations.runtimeClasspath)
+ inputs.files(depsConfiguration)
outputs.file(depsFile)
doLast {
if (!depsFile.exists()) {
- logger.warn("WARNING: Missing ${depsFile.name} in ${projectDir}. " +
+ logger.warn("WARNING: Missing ${relativePath(depsFile)} in
${projectDir}. " +
Review Comment:
Every baseline already works this way; deleting any module's
`runtime-deps.txt` also only warns. I'd rather change it for all modules in a
separate PR.
##########
runtime-deps.gradle:
##########
@@ -78,14 +87,14 @@ tasks.register('generateRuntimeDeps') {
}
}
-tasks.register('checkRuntimeDeps') {
+tasks.maybeCreate('checkRuntimeDeps').configure {
group = 'verification'
description = 'Verify runtime dependencies match the checked-in baseline'
- inputs.files(configurations.runtimeClasspath)
+ inputs.files(depsConfiguration)
Review Comment:
That's expected: checking the hive distribution means resolving its
configuration, like every other baseline. Hive just wasn't checked before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]