kevinjqliu commented on code in PR #18660:
URL: https://github.com/apache/iceberg/pull/18660#discussion_r4556665532


##########
kafka-connect/build.gradle:
##########
@@ -253,6 +257,11 @@ 
project(':iceberg-kafka-connect:iceberg-kafka-connect-runtime') {
     it.file in [hiveDistZip.archiveFile.get().asFile, 
hiveDistTar.archiveFile.get().asFile]
   }
 
+  // track main and hive distributions separately; set properties before each 
apply
+  ext.runtimeDepsFile = 'main/runtime-deps.txt'
+  apply from: "${rootDir}/runtime-deps.gradle"
+  ext.runtimeDepsFile = 'hive/runtime-deps.txt'
+  ext.runtimeDepsConfiguration = configurations.hive
   apply from: "${rootDir}/runtime-deps.gradle"

Review Comment:
   Thanks I like this solution. 
   Pushed a commit to use `trackRuntimeDeps(configuration, path)`. 
kafka-connect calls it for `main` and `hive`. Other modules keep the plain 
`apply from:` and still track `runtimeClasspath` in `runtime-deps.txt`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to