rdblue commented on code in PR #18503:
URL: https://github.com/apache/iceberg/pull/18503#discussion_r4567997766


##########
format/spec.md:
##########
@@ -1269,6 +1271,8 @@ The snapshot summary's `operation` field is used by some 
operations, like snapsh
 
 For other optional snapshot summary fields, see [Appendix 
F](#optional-snapshot-summary-fields).
 
+The `encrypted-key-metadata` and `encrypted-by-id` fields must be set together.

Review Comment:
   This should be more clear. I'm also not convinced that it is a good idea 
because you don't have to set `encrypted-by-id` for plaintext keys. A more 
accurate statement is "`encrypted-by-id` may only be set when 
`encrypted-key-metadata` is set".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to