rdblue commented on code in PR #18503:
URL: https://github.com/apache/iceberg/pull/18503#discussion_r4568005766


##########
format/spec.md:
##########
@@ -2263,6 +2267,10 @@ Snapshot timestamp changes:
 * When committed while the table is at version 4 or higher, a snapshot's 
`timestamp-ms` must be strictly greater than its parent snapshot's 
`timestamp-ms` on the same branch.
 * Snapshots with no parent and snapshots that existed before a table was 
upgraded to v4 are not constrained.
 
+Snapshot encryption key changes:
+
+* Writers may store the root manifest's encryption key metadata directly in 
the snapshot's `encrypted-key-metadata` and `encrypted-by-id` fields

Review Comment:
   ```suggestion
   * Writers must store the root manifest's encryption key metadata directly in 
a snapshot's `encrypted-key-metadata`. The key metadata may be encrypted by the 
key identified by `encrypted-by-id`.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to