anuragmantri commented on code in PR #17622:
URL: https://github.com/apache/iceberg/pull/17622#discussion_r4570502660


##########
api/src/main/java/org/apache/iceberg/actions/RepairTable.java:
##########
@@ -33,6 +33,9 @@ public interface RepairTable extends 
SnapshotUpdate<RepairTable, RepairTable.Res
    * Repairs incorrect metrics of manifest entries, such as record counts, 
file sizes and column
    * level statistics, by comparing them against the underlying data and 
delete files.
    *
+   * <p>Deletion vectors (delete blobs stored in Puffin files) are not 
verified or repaired. Metrics

Review Comment:
   Two small things in javadoc:
   - `Result.repairedManifests()` returns the manifests that were replaced, not 
the new ones. Could the `Result` javadoc say that? 
   - This sentence mentions only NaN-safe bounds. The Spark action keeps all 
float, double, geometry and geography bounds as stored, as its class javadoc 
says. Could this say the same here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to