rahulsmahadev commented on code in PR #17622:
URL: https://github.com/apache/iceberg/pull/17622#discussion_r4586815884


##########
api/src/main/java/org/apache/iceberg/actions/RepairTable.java:
##########
@@ -33,6 +33,9 @@ public interface RepairTable extends 
SnapshotUpdate<RepairTable, RepairTable.Res
    * Repairs incorrect metrics of manifest entries, such as record counts, 
file sizes and column
    * level statistics, by comparing them against the underlying data and 
delete files.
    *
+   * <p>Deletion vectors (delete blobs stored in Puffin files) are not 
verified or repaired. Metrics

Review Comment:
   Thanks! Updated both: the `Result` javadoc now says `repairedManifests()` 
returns the manifests that were replaced by repaired copies (or would be in a 
dry run), and the `repairFileMetrics()` javadoc lists the float, double, 
geometry and geography bounds. I also added geography to the Spark action's 
class javadoc, which only mentioned floating-point and geometry bounds.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to