badalprasadsingh commented on code in PR #2588:
URL: https://github.com/apache/iceberg-go/pull/2588#discussion_r4574971974


##########
catalog/rest/rest.go:
##########
@@ -763,7 +763,9 @@ func handleNon200(rsp *http.Response, override 
map[int]error, typeOverride map[s
                e.wrapping = ErrRESTError
        case 419:
                e.wrapping = ErrAuthorizationExpired
-       case http.StatusNotImplemented:
+       case http.StatusNotAcceptable, http.StatusNotImplemented:
+               // 406 is the spec's UnsupportedOperationResponse; 501 is what 
a server
+               // without the operation may answer instead. Both are "not 
supported".
                e.wrapping = iceberg.ErrNotImplemented

Review Comment:
   a 406 used to match: "rest.ErrRESTError" -> now it does not -> any caller 
that branchd on it now change behavior
   
   can you please add a compatibility note in releases.md?
   or, then keep both matches (501 then gains ErrRESTError too) -> you can 
check the example of "errCommitBadRequest" and "ErrCommitFailed"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to