laskoviymishka commented on code in PR #2588:
URL: https://github.com/apache/iceberg-go/pull/2588#discussion_r4577953627


##########
catalog/rest/rest.go:
##########
@@ -125,6 +125,10 @@ var (
        errCommitForbidden    = fmt.Errorf("%w: %w", ErrForbidden, 
table.ErrCommitRejected)
        errCommitNoSuchTable  = fmt.Errorf("%w: %w", catalog.ErrNoSuchTable, 
table.ErrCommitRejected)
 
+       // errNotSupported is a 406 or 501. It keeps ErrRESTError, which a 406
+       // matched before it also became iceberg.ErrNotImplemented.

Review Comment:
   Could the comment also say that a 501 now matches `ErrRESTError`? On `main` 
it matched only `iceberg.ErrNotImplemented` 
([base](https://github.com/apache/iceberg-go/blob/8d13e317c79f36f38f52a16b2f81f1d966f1fc27/catalog/rest/rest.go#L766-L767)),
 so that part is new, and the description's "still" reads as if it weren't.
   
   ```suggestion
        // matched before it also became iceberg.ErrNotImplemented. A 501 gains
        // ErrRESTError here, like every other 5xx.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to