ShivanshhhG commented on PR #17914: URL: https://github.com/apache/iceberg/pull/17914#issuecomment-6888338882
Thanks @adutra and @singhpk234! I have updated the PR following the agreed approach: 1. Retained the static, process-wide `SIGNED_COMPONENT_CACHE` across `FileIO` instances. 2. Included the full `properties()` map in the cache `Key`, ensuring that all credential/auth/remote-signing-config and endpoint variations naturally isolate cache entries, while clients sharing identical properties safely share cached signatures. 3. Restored the case-insensitive `Cache-Control` handling and added test coverage verifying both cross-principal isolation and cache sharing across distinct client instances with identical properties. 4. Verified that all unit tests and Spotless checks in `:iceberg-aws` pass cleanly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
