xndai commented on code in PR #1124:
URL: https://github.com/apache/iceberg-cpp/pull/1124#discussion_r4576962006
##########
src/iceberg/util/location_util.h:
##########
@@ -39,6 +40,32 @@ class ICEBERG_EXPORT LocationUtil {
/// not validated.
static std::string_view ParseScheme(std::string_view location);
+ /// \brief Whether a location starts with a URI scheme.
+ ///
+ /// This is the spec's test for an absolute path (see "Paths in Metadata"):
Review Comment:
The spec says exactly this:
```
The recommended convention for table location is to not end in a path
separator because the join process would add a second separator character. (See
example below.)
```
https://iceberg.apache.org/spec/#path-resolution
So it recommend not to include the trailing / for table location, but this
diff go ahead and enforce that. It's very problematic for S3 if you includes
double back slash as they are not treated as path so s3://foo//bar is actually
different then s3://foo/bar. Super confusing and error prone. That's why i just
enforce that in the diff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]