xndai commented on code in PR #1124:
URL: https://github.com/apache/iceberg-cpp/pull/1124#discussion_r4576987645
##########
src/iceberg/util/location_util.h:
##########
@@ -39,6 +40,32 @@ class ICEBERG_EXPORT LocationUtil {
/// not validated.
static std::string_view ParseScheme(std::string_view location);
+ /// \brief Whether a location starts with a URI scheme.
+ ///
+ /// This is the spec's test for an absolute path (see "Paths in Metadata"):
Review Comment:
sure. but the difference needs to be called out. So will make this change
after previous thread is resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]