laskoviymishka commented on code in PR #3695:
URL: https://github.com/apache/iceberg-rust/pull/3695#discussion_r4577777715
##########
crates/iceberg/src/spec/table_metadata_builder.rs:
##########
@@ -2878,6 +2879,49 @@ mod tests {
assert_eq!(metadata.default_partition_spec().as_ref(), &expected);
}
+ #[test]
+ fn test_metadata_change_after_a_fast_branch_snapshot_is_refused_in_build()
{
Review Comment:
Could we add a companion case where the skew stays inside the one-minute
tolerance (say 30s) and the second `build()` still succeeds? This test is the
only one that reaches the metadata-log check with a previous-file entry, so
nothing would catch the check being tightened past the tolerance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]