c-thiel commented on code in PR #3695:
URL: https://github.com/apache/iceberg-rust/pull/3695#discussion_r4578432223
##########
crates/iceberg/src/spec/table_metadata_builder.rs:
##########
@@ -2878,6 +2879,49 @@ mod tests {
assert_eq!(metadata.default_partition_spec().as_ref(), &expected);
}
+ #[test]
+ fn test_metadata_change_after_a_fast_branch_snapshot_is_refused_in_build()
{
Review Comment:
Added `test_metadata_change_after_a_slightly_fast_branch_snapshot_builds` in
[fa4c201](https://github.com/apache/iceberg-rust/pull/3695/commits/fa4c201e60e4c3f6c55ca160d9767e288596537b):
the same setup with 30 s of skew, where the second `build()` succeeds and the
entry for the previous file is the last metadata-log entry. Both tests now
share a small helper. With the tolerance cut to 10 s, the new test fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]