rdblue commented on code in PR #18984:
URL: https://github.com/apache/iceberg/pull/18984#discussion_r4580478509
##########
core/src/main/java/org/apache/iceberg/TrackingBuilder.java:
##########
@@ -23,26 +23,27 @@
import org.apache.iceberg.util.ByteBuffers;
class TrackingBuilder {
- private final long newSnapshotId;
- private final Long snapshotId;
- private final Long fileSequenceNumber;
- private final Long firstRowId;
- private EntryStatus status;
- private Long dataSequenceNumber;
- private Long modifiedSnapshotId;
- private byte[] deletedPositions;
- private byte[] replacedPositions;
-
/**
* Creates a builder for a newly added file.
*
* @param newSnapshotId the snapshot ID in which the new tracking instance
will be committed
* @return a builder for a newly added file
*/
- static TrackingBuilder added(long newSnapshotId) {
+ static TrackingBuilder added(Long newSnapshotId) {
Review Comment:
This is needed for manifest append because the writer uses a `null` snapshot
ID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]