rdblue commented on code in PR #18984:
URL: https://github.com/apache/iceberg/pull/18984#discussion_r4580480459
##########
core/src/main/java/org/apache/iceberg/TrackingBuilder.java:
##########
@@ -76,7 +77,17 @@ static Tracking replaced(Tracking source, long
newSnapshotId) {
return terminal(EntryStatus.REPLACED, source, newSnapshotId);
}
- private TrackingBuilder(long newSnapshotId) {
+ private final Long newSnapshotId;
+ private final Long snapshotId;
+ private final Long fileSequenceNumber;
+ private final Long firstRowId;
+ private EntryStatus status;
+ private Long dataSequenceNumber;
+ private Long modifiedSnapshotId;
+ private byte[] deletedPositions;
+ private byte[] replacedPositions;
Review Comment:
These are relocated below the static methods to keep the class details
together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]