rdblue commented on a change in pull request #2163:
URL: https://github.com/apache/iceberg/pull/2163#discussion_r568180872
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java
##########
@@ -210,7 +218,7 @@ private void cleanup(JobContext jobContext) throws
IOException {
JobConf conf = jobContext.getJobConf();
// If there are reducers, then every reducer will generate a result file.
// If this is a map only task, then every mapper will generate a result
file.
- int expectedFiles = conf.getNumReduceTasks() != 0 ?
conf.getNumReduceTasks() : conf.getNumMapTasks();
+ int expectedFiles = conf.getNumReduceTasks() > 0 ?
conf.getNumReduceTasks() : conf.getNumMapTasks();
Review comment:
Is this fixing a bug?
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java
##########
@@ -82,11 +82,13 @@ public boolean needsTaskCommit(TaskAttemptContext context) {
/**
* Collects the generated data files and creates a commit file storing the
data file list.
- * @param context The job context
+ * @param ctx The task attempt context
Review comment:
What is the value of renaming this to `ctx`? We generally prefer the
longer names because they are easier to read and to type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
