rdblue commented on a change in pull request #2163:
URL: https://github.com/apache/iceberg/pull/2163#discussion_r569674726
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java
##########
@@ -82,11 +82,13 @@ public boolean needsTaskCommit(TaskAttemptContext context) {
/**
* Collects the generated data files and creates a commit file storing the
data file list.
- * @param context The job context
+ * @param ctx The task attempt context
Review comment:
Okay, I understand. Let's do this, but use a better name that doesn't
violate our best practices. How about `originalContext` or
`contextBeforeEnrichment` instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
