openinx commented on a change in pull request #1956:
URL: https://github.com/apache/iceberg/pull/1956#discussion_r568279327
##########
File path:
flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogTable.java
##########
@@ -136,13 +133,23 @@ public void testCreateTableIfNotExists() {
sql("DROP TABLE tl");
AssertHelpers.assertThrows("Table 'tl' should be dropped",
- NoSuchTableException.class, "Table does not exist: db.tl", () ->
table("tl"));
+ NoSuchTableException.class,
+ "Table does not exist: " + getFullQualifiedTableName("tl"),
+ () -> table("tl"));
- sql("CREATE TABLE IF NO EXISTS tl(id BIGINT)");
+ sql("CREATE TABLE IF NOT EXISTS tl(id BIGINT)");
Assert.assertEquals(Maps.newHashMap(), table("tl").properties());
- sql("CREATE TABLE IF NOT EXISTS tl(id BIGINT) WITH
('location'='/tmp/location')");
- Assert.assertEquals("Should still be the old table.", Maps.newHashMap(),
table("tl").properties());
+ final String uuid = UUID.randomUUID().toString();
Review comment:
Thanks a lot for the unit tests improvement !
##########
File path:
flink/src/test/java/org/apache/iceberg/flink/FlinkCatalogTestBase.java
##########
@@ -119,6 +123,12 @@ protected String warehouseRoot() {
}
}
+ protected String getFullQualifiedTableName(String tableName) {
+ final List<String> levels = new
ArrayList<>(Arrays.asList(icebergNamespace.levels()));
Review comment:
Nit: in apache iceberg, we usually use the unified `Lists.newArrayLists`
to create a new ArrayList.
##########
File path:
flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogTable.java
##########
@@ -107,7 +107,7 @@ public void testRenameTable() {
() -> getTableEnv().from("tl")
);
Assert.assertEquals(
- Collections.singletonList(TableColumn.of("id", DataTypes.BIGINT())),
+ Collections.singletonList(TableColumn.physical("id",
DataTypes.BIGINT())),
Review comment:
@stevenzwu , do you think this issue need to fix in this PR ? I think
we'd better to...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
