openinx commented on a change in pull request #1956:
URL: https://github.com/apache/iceberg/pull/1956#discussion_r566823841
##########
File path: flink/src/test/java/org/apache/iceberg/flink/FlinkTestBase.java
##########
@@ -34,8 +37,27 @@
import org.apache.iceberg.relocated.com.google.common.collect.Lists;
import org.junit.AfterClass;
import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.rules.TemporaryFolder;
-public abstract class FlinkTestBase extends AbstractTestBase {
+public abstract class FlinkTestBase extends TestBaseUtils {
+
+ private static final int DEFAULT_PARALLELISM = 4;
+
+ private static final Configuration config = new Configuration()
+ // disable classloader check as Avro may cache class/object in the
serializers.
+ .set(CoreOptions.CHECK_LEAKED_CLASSLOADER, false);
Review comment:
I think we need to disable the `CoreOptions.CHECK_LEAKED_CLASSLOADER`
here ? Seems like we usually validation the iceberg tables results once we've
terminated the flink job.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
