pvary commented on code in PR #18692:
URL: https://github.com/apache/iceberg/pull/18692#discussion_r4585331953


##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java:
##########
@@ -268,6 +249,42 @@ public void doCommit(ViewMetadata base, ViewMetadata 
metadata) {
         "Committed to view {} with the new metadata location {}", fullName, 
newMetadataLocation);
   }
 
+  private void updateHmsTable(
+      Table tbl,
+      ViewMetadata base,
+      ViewMetadata metadata,
+      String baseMetadataLocation,
+      String newMetadataLocation) {
+    tbl.setSd(
+        HiveOperationsBase.storageDescriptor(
+            metadata.schema(), metadata.location(), false)); // set to pick up 
any schema changes

Review Comment:
   ```suggestion
       // set to pick up any schema changes
       tbl.setSd(
           HiveOperationsBase.storageDescriptor(
               metadata.schema(), metadata.location(), false /* 
hiveEngineEnabled */));
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to