anoopj opened a new pull request, #18999: URL: https://github.com/apache/iceberg/pull/18999
The Spark `ExpireSnapshots` action computes expired files through the `all_manifests` metadata table, which is not supported for v4 tables. Guard `ExpireSnapshotsSparkAction.expireFiles()` to reject v4 before the expiration commit so the table is never partially mutated, reading refreshed metadata so a stale handle cannot slip an already-upgraded v4 table through. Only this Spark action is guarded; core and other-engine expiration stay reachable on v4 (they read manifests directly, not metadata tables). The guard is also best-effort against a concurrent v3 to v4 upgrade committed between the check and RemoveSnapshots' own refresh; closing that race atomically would need a core-level gate. Retarget TestExpireSnapshotsAction to v2/v3, gate the expire-using TestRewriteTablePaths tests to v2/v3 while keeping v4 coverage for the rest, and add TestExpireSnapshotsActionV4 for the v4 ehavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
