amogh-jahagirdar commented on code in PR #18999:
URL: https://github.com/apache/iceberg/pull/18999#discussion_r4590621541
##########
spark/v4.2/spark/src/main/java/org/apache/iceberg/spark/actions/ExpireSnapshotsSparkAction.java:
##########
@@ -153,8 +155,12 @@ public ExpireSnapshotsSparkAction
cleanExpiredMetadata(boolean clean) {
*/
public Dataset<FileInfo> expireFiles() {
if (expiredFileDS == null) {
- // fetch metadata before expiration
- TableMetadata originalMetadata = ops.current();
+ TableMetadata originalMetadata = ops.refresh();
+ int formatVersion = originalMetadata.formatVersion();
+ ValidationException.check(
Review Comment:
discussed offline with Anoop, it's just a temporary state anyways just to
prevent bad cleanups and typically the intent of a caller here is to run a
distributed cleanup so a failure is a clearer way of saying it's unsupported.
He's doing 2 separately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]