aokolnychyi commented on a change in pull request #2193:
URL: https://github.com/apache/iceberg/pull/2193#discussion_r568310060



##########
File path: 
spark3-extensions/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDelete.scala
##########
@@ -55,8 +54,6 @@ case class RewriteDelete(spark: SparkSession) extends 
Rule[LogicalPlan] with Rew
   import ExtendedDataSourceV2Implicits._
   import RewriteRowLevelOperationHelper._
 
-  override def resolver: Resolver = spark.sessionState.conf.resolver

Review comment:
       Moved this to parent as I need both `conf` and `resolver` now.

##########
File path: 
spark3-extensions/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteMergeInto.scala
##########
@@ -224,22 +216,6 @@ case class RewriteMergeInto(spark: SparkSession) extends 
Rule[LogicalPlan] with
     }
     !(actions.size == 1 && hasUnconditionalDelete(actions.headOption))
   }
-
-  private def buildWritePlan(childPlan: LogicalPlan, table: Table): 
LogicalPlan = {

Review comment:
       Moved to parent.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to