aokolnychyi commented on a change in pull request #2193:
URL: https://github.com/apache/iceberg/pull/2193#discussion_r568840738
##########
File path:
spark3-extensions/src/main/scala/org/apache/spark/sql/catalyst/optimizer/OptimizeConditionsInRowLevelOperations.scala
##########
@@ -35,6 +35,10 @@ object OptimizeConditionsInRowLevelOperations extends
Rule[LogicalPlan] {
if
!SubqueryExpression.hasSubquery(cond.getOrElse(Literal.TrueLiteral)) &&
isIcebergRelation(table) =>
val optimizedCond =
optimizeCondition(cond.getOrElse(Literal.TrueLiteral), table)
d.copy(condition = Some(optimizedCond))
+ case u @ UpdateTable(table, _, cond)
Review comment:
Took another look. Not sure, actually. We need both branches to get
`cond`, the main shared logic is in a separate method but I'd welcome any ideas
I could overlook.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
