dramaticlly commented on code in PR #18932:
URL: https://github.com/apache/iceberg/pull/18932#discussion_r4591201499
##########
spark/v4.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteTablePathsAction.java:
##########
@@ -577,7 +619,12 @@ public void testPositionDeletesAcrossFiles() throws
Exception {
// We have one more snapshot, an additional manifest list, and a new
(delete) manifest,
// and an additional position delete
- checkFileNum(4, 3, 3, 13, result);
+ assertThat(result)
+ .hasVersionFiles(4)
+ .hasManifestLists(3)
+ .hasManifests(3)
+ .hasContentFiles(3)
+ .hasNoOtherFiles();
Review Comment:
Thanks for the callout, I think `build()` might be overkill here, the
existing fluent assertion in assertJ does not tend to force closure and let the
unit test author to pick what condition they want to assert with, I think we
can keep the same with RewriteTablePathResultAssert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]