RussellSpitzer commented on PR #18935: URL: https://github.com/apache/iceberg/pull/18935#issuecomment-6930083927
@danielcweeks + @rshdhere I went over all your comments and adjusted the PR. The biggest change is the metrics conf handling behavior. Previously we were doing a bit of reverse name lookup and just treating all the fields of File like a struct. To try to match our text in the Spec a bit better and from Dan's suggestion I changed it to only count the 3 recommended fields as metric-able by default. The others are only set to "count" unless the table default is none. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
