RussellSpitzer commented on code in PR #18935:
URL: https://github.com/apache/iceberg/pull/18935#discussion_r4591756984
##########
core/src/main/java/org/apache/iceberg/MetricsConfig.java:
##########
@@ -190,6 +190,11 @@ public Set<Integer> struct(Types.StructType struct,
Iterable<Set<Integer>> field
return null;
}
+ @Override
+ public Set<Integer> file(Types.FileType file, Iterable<Set<Integer>>
fieldResults) {
+ return struct(file.asStruct(), fieldResults);
+ }
Review Comment:
Changed this around pretty dramatically. I didn't have that later in the
series.
So the new version is to define the exact offsets we consider *real* fields
(uri, size, content) and only those count towards our limit. I put the default
for the other file types as "count" unless the table default is "non".
So file types now behave a little different
1. Only uri, size and content are included during the "limit" phase of
metric collectioN
2. inline, checksum are default to *count* if there is still room
3. Inline, checksum can be made "none" if they set none as the Table default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]