manuzhang commented on code in PR #1137:
URL: https://github.com/apache/iceberg-cpp/pull/1137#discussion_r4594994423
##########
src/iceberg/avro/avro_direct_decoder.cc:
##########
@@ -602,15 +602,16 @@ Status DecodeFieldToBuilder(const ::avro::NodePtr&
avro_node, ::avro::Decoder& d
const SchemaField& projected_field,
const arrow::MetadataColumnContext&
metadata_context,
::arrow::ArrayBuilder* array_builder,
DecodeContext& ctx) {
- if (projection.kind == FieldProjection::Kind::kNull) {
+ const bool is_row_lineage =
Review Comment:
It look we can keep following logic in one util method and reuse for
`avro_data_util.cc`, `avro_direct_decoder.cc` and `parquet_data_util.cc`.
```
const bool is_row_lineage =
MetadataColumns::IsRowLineageColumn(projected_field.field_id());
is_row_lineage && !metadata_context.first_row_id.has_value();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]