manuzhang commented on code in PR #1137:
URL: https://github.com/apache/iceberg-cpp/pull/1137#discussion_r4595114167


##########
src/iceberg/test/avro_test.cc:
##########
@@ -964,6 +965,11 @@ TEST_P(AvroReaderParameterizedTest, ReadPhysicalLineage) {
   ICEBERG_UNWRAP_OR_FAIL(auto reader, OpenRowLineageReader(schema, 100L));
 
   VerifyNextBatch(*reader, R"([[1, 100, null], [2, 777, 8], [3, 102, null]])");
+
+  ICEBERG_UNWRAP_OR_FAIL(auto reader_without_row_id,
+                         OpenRowLineageReader(schema, std::nullopt, 7L));
+  VerifyNextBatch(*reader_without_row_id,
+                  R"([[1, null, null], [2, null, null], [3, null, null]])");

Review Comment:
   Can we also cover reading stored `_row_id` with a null sequence number for 
both Avro and parquet? For example:
   
   ```
   Physical lineage:  (777, null)
   File metadata:    first_row_id=100, data_sequence_number=7
   Expected lineage: (777, 7)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to