pallevam commented on PR #18551: URL: https://github.com/apache/iceberg/pull/18551#issuecomment-6947451725
@Baunsgaard Thanks for the review, all three are addressed: 1. Switched to `IntMath.divide(..., RoundingMode.CEILING)` like the other actions, so the calculation no longer overflows. 2. Moved the calculation into a `@VisibleForTesting` helper, `listedFilePartitions`, with tests for small listings, larger listings, and `Integer.MAX_VALUE`. The overflow test fails with the previous calculation. 3. Applied the fix to Spark 3.5, 4.0 and 4.1 as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
