szehon-ho commented on code in PR #17622:
URL: https://github.com/apache/iceberg/pull/17622#discussion_r4599863338


##########
api/src/main/java/org/apache/iceberg/actions/RepairTable.java:
##########
@@ -33,6 +33,10 @@ public interface RepairTable extends 
SnapshotUpdate<RepairTable, RepairTable.Res
    * Repairs incorrect metrics of manifest entries, such as record counts, 
file sizes and column
    * level statistics, by comparing them against the underlying data and 
delete files.
    *
+   * <p>Deletion vectors (delete blobs stored in Puffin files) are not 
verified or repaired. Metrics
+   * that cannot be reconstructed from files are kept as stored: NaN counts 
and the bounds of float,

Review Comment:
   Could we just say that this action preserves these metrics? They can 
sometimes be recovered from footer statistics, such as Parquet’s optional geo 
bounding boxes and NaN counts, so “cannot be reconstructed from files” is too 
broad. I’m fine with adding support for those cases in a follow-up.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to