rdblue commented on code in PR #18875:
URL: https://github.com/apache/iceberg/pull/18875#discussion_r4607229621


##########
api/src/main/java/org/apache/iceberg/Metrics.java:
##########
@@ -245,49 +244,14 @@ public Map<Integer, ByteBuffer> upperBounds() {
   }
 
   /**
-   * Get the total uncompressed size in memory in bytes of non-null values, 
for all fields where it
-   * was collected.
+   * Returns {@code null}.
    *
-   * @return a Map of fieldId to total uncompressed size in bytes
-   */
-  public Map<Integer, Long> totalBytes() {
-    return totalBytes;
-  }
-
-  /**
-   * Get the average value size in memory (uncompressed) in bytes over 
non-null values, for all
-   * fields where it was collected.
-   *
-   * @return a Map of fieldId to average value size in bytes
-   * @deprecated since 1.13.0, will be removed in 2.0.0; use {@link 
#totalBytes()} instead.
+   * @return null

Review Comment:
   I don't know about removing the Javadoc completely and just saying it 
returns null. Some explanation of why would be nice.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to