rdblue commented on code in PR #18875:
URL: https://github.com/apache/iceberg/pull/18875#discussion_r4617833369
##########
api/src/main/java/org/apache/iceberg/ContentFile.java:
##########
@@ -105,28 +105,13 @@ default boolean tightStats() {
}
/**
- * Returns map from column ID to the total uncompressed size in memory in
bytes of non-null values
- * if collected, null otherwise.
+ * Returns {@code null}.
*
- * <p>This statistic is not persisted in manifests prior to v4, so it is
generally only present on
- * newly created or written files, and is null for files read back from such
manifests.
- */
- default Map<Integer, Long> totalBytes() {
- return null;
- }
-
- /**
- * Returns if collected, map from column ID to its average value size in
memory (uncompressed) in
- * bytes over non-null values, null otherwise.
- *
- * <p>This statistic is not persisted in manifests prior to v4, so it is
generally only present on
- * newly created or written files, and is null for files read back from such
manifests.
- *
- * @deprecated since 1.13.0, will be removed in 2.0.0; use {@link
#totalBytes()} instead.
+ * @deprecated since 1.13.0, will be removed in 2.0.0
*/
@Deprecated
default Map<Integer, Integer> avgValueSizes() {
- return Metrics.avgValueSizes(totalBytes(), valueCounts(),
nullValueCounts());
+ return null;
Review Comment:
Wait, sorry about this. I think `null` is the right choice. I don't know
what I was thinking when I reviewed last night.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]