manuzhang commented on code in PR #1104:
URL: https://github.com/apache/iceberg-cpp/pull/1104#discussion_r4610676617


##########
src/iceberg/update/pending_update.h:
##########
@@ -93,6 +93,11 @@ class ICEBERG_EXPORT PendingUpdate : public ErrorCollector,
 
   /// \brief Discard this generation's staging, retaining applied operation 
intent.
   virtual Status CleanStaged() { return {}; }
+
+  /// \brief Prepare retry-safe state after the transaction metadata is 
refreshed.
+  /// Do not delete staged files that later updates may still reference.

Review Comment:
   This feels a bit weird. We usually describe what it and its implementation 
should do. Besides, it's unclear when it's invoked and why we should be 
concerned about staged files.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to