wgtmac commented on code in PR #1104:
URL: https://github.com/apache/iceberg-cpp/pull/1104#discussion_r4611998726
##########
src/iceberg/update/pending_update.h:
##########
@@ -93,6 +93,11 @@ class ICEBERG_EXPORT PendingUpdate : public ErrorCollector,
/// \brief Discard this generation's staging, retaining applied operation
intent.
virtual Status CleanStaged() { return {}; }
+
+ /// \brief Prepare retry-safe state after the transaction metadata is
refreshed.
+ /// Do not delete staged files that later updates may still reference.
Review Comment:
Updated the comment to explain when Transaction calls this hook and what
implementations should reset. The operation's intent and staged files are
retained because later updates in the transaction may still reference them.
`RewriteManifests::CleanUncommitted` now only clears cached rewrite state
and it no longer deletes physical files. Generated paths remain in
SnapshotUpdate's staging registry for terminal cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]