Fokko commented on code in PR #4389:
URL: https://github.com/apache/iceberg-python/pull/4389#discussion_r4611830735


##########
pyiceberg/schema.py:
##########
@@ -207,13 +220,25 @@ def find_field(self, name_or_id: str | int, 
case_sensitive: bool = True) -> Nest
                 raise ValueError(f"Could not find field with id: {name_or_id}")
             return self._lazy_id_to_field[name_or_id]
 
+        field = self._find_field_or_none(name_or_id, case_sensitive)

Review Comment:
   Since this is the user facing change, could we also document the collision 
in the public docstrings? `find_field` and `select` still only say `ValueError` 
is raised when the field cannot be found. Something like `ValueError: When 
case_sensitive is False and two fields have names that differ only by case.` in 
both.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to