rahulsmahadev commented on code in PR #4389:
URL: https://github.com/apache/iceberg-python/pull/4389#discussion_r4616963452


##########
pyiceberg/schema.py:
##########
@@ -207,13 +220,25 @@ def find_field(self, name_or_id: str | int, 
case_sensitive: bool = True) -> Nest
                 raise ValueError(f"Could not find field with id: {name_or_id}")
             return self._lazy_id_to_field[name_or_id]
 
+        field = self._find_field_or_none(name_or_id, case_sensitive)

Review Comment:
   Done in 6397704c: `find_field` and `select` now list the collision under 
`Raises`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to