flyrain commented on code in PR #11041:
URL: https://github.com/apache/iceberg/pull/11041#discussion_r4622250553
##########
format/view-spec.md:
##########
@@ -160,7 +179,95 @@ Each entry in `version-log` is a struct with the following
fields:
| _required_ | `timestamp-ms` | Timestamp when the view's
`current-version-id` was updated (ms from epoch) |
| _required_ | `version-id` | ID that `current-version-id` was set to |
-## Appendix A: An Example
+#### Storage Table Identifier
+
+The table identifier for the storage table that stores the precomputed results.
+
+| Requirement | Field name | Description |
+|-------------|----------------|-------------|
+| _required_ | `namespace` | A list of strings for namespace levels |
+| _required_ | `name` | A string specifying the name of the table |
+| _optional_ | `catalog` | A string specifying the name of the catalog.
When `null` or not set, the catalog in which the materialized view is stored is
used |
Review Comment:
> "storage-table": { "namespace": "default", "name": "event_agg_mv__storage"
}
This example assumes the storage table is in the same catalog as the view,
right? If that’s always required, I don’t think we need the `catalog` field.
What I’m trying to understand is how engines resolve `catalog` when a user
sets it explicitly. For example, if the user sets it to `prod`, should the
engine look up `prod` in its own catalog configuration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]