flyrain commented on code in PR #11041:
URL: https://github.com/apache/iceberg/pull/11041#discussion_r4633584397


##########
format/view-spec.md:
##########
@@ -160,7 +179,95 @@ Each entry in `version-log` is a struct with the following 
fields:
 | _required_  | `timestamp-ms` | Timestamp when the view's 
`current-version-id` was updated (ms from epoch) |
 | _required_  | `version-id`   | ID that `current-version-id` was set to |
 
-## Appendix A: An Example
+#### Storage Table Identifier
+
+The table identifier for the storage table that stores the precomputed results.
+
+| Requirement | Field name     | Description |
+|-------------|----------------|-------------|
+| _required_  | `namespace`    | A list of strings for namespace levels |
+| _required_  | `name`         | A string specifying the name of the table |
+| _optional_  | `catalog`      | A string specifying the name of the catalog. 
When `null` or not set, the catalog in which the materialized view is stored is 
used |

Review Comment:
   Even though this field is optional, it’s part of the metadata, so its value 
applies to every client that reads it, including every Spark application. Each 
client will have its own catalog name. I'm not sure how this field can be 
useful. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to