binarybrain-009 commented on PR #18692: URL: https://github.com/apache/iceberg/pull/18692#issuecomment-7002458736
@pvary Addressed in ad48a5f2a. The metadata-location check is back in doCommit, the helper only updates the HMS table, and I applied the newline and storage-descriptor suggestions. All 14 TestHiveViewCommits tests and Hive formatting/checkstyle checks pass. Could you take another look? These latest follow-ups were generated with Codex; the disclosure distinguishes them from the earlier changes I personally reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
