allthingssecurity commented on PR #18764:
URL: https://github.com/apache/iceberg/pull/18764#issuecomment-7002475095

   Thanks @jbonofre for the review. Changes in e7fd3b1:
   - VariantBinaryWriter now keeps its buffer in a thread-local, like 
UUIDWriter and DecimalWriter, and variants() returns a shared instance again.
   - The test shares one writer between both threads, and a second test shares 
one IcebergEncoder over (id int, data variant) and decodes every message with 
IcebergDecoder.
   - await and get now use a 60 second timeout.
   - The class and methods are package-private and the methods have no test 
prefix.
   
   Both tests fail on main (another thread's value comes back) and also fail 
with the previous per-call writer. With this change they passed 31 of 31 runs. 
The core `org.apache.iceberg.avro` tests (300) and, in iceberg-data, the Avro 
`TestGenericData` (53), `TestGenericReadProjection` (14), 
`TestSingleMessageEncoding` (12), `TestGenericFormatModel` (423), 
`TestGenericFileWriterFactory` (31), `TestLocalScan` (42) and 
`TestRecordVariantShreddingAnalyzer` (18) pass with no failures, as do 
spotless, checkstyle and revapi (`:iceberg-core:check -x test`).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to